Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tlsEnabled default value. #4164

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix tlsEnabled default value. #4164

merged 2 commits into from
Oct 24, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Oct 24, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at c59d1c2

Summary

🐛📝🚀

Fixed a bug and a typo in the adminer deployment files. Quoted the tlsEnabled variable in Kubefile and used the correct image name in README.md.

tlsEnabled fixed
sealos run matches Kubefile
autumn of errors

Walkthrough

@zzjin zzjin added this to the v5.0 milestone Oct 24, 2023
@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 24, 2023 •
edited
Loading

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 956
✅ Successful 375
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@bxy4543 bxy4543 merged commit 7995c16 into labring:main Oct 24, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxy4543 bxy4543 bxy4543 approved these changes

Assignees
No one assigned
Labels
area/cloud size/XS
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zzjin @sealos-ci-robot @bxy4543